Railcraft compat by LonelyxiyaOVO · Pull Request #384 · CleanroomMC/GroovyScript

LonelyxiyaOVO · 2026-05-05T12:26:36Z

bro Railcraft compat

Wizzerinus

I'm not a maintainer of this mod, just mentioning some things I noticed ;)

WaitingIdly

a few other things:

instead of magic numbers as defaults, use the railcraft defaults directly - ie IRollingMachineCrafter.DEFAULT_PROCESS_TIME.
run /gs generateWiki or enabling dev_generate_wiki in gradle.properties - check the log to ensure no warnings/missing lang keys.
wizz also brought up great points, listen to those.

WaitingIdly · 2026-05-05T14:10:44Z

+
+        @Property(comp = @Comp(gte = 0))
+        private int time = 200;
+        private final List<IOutputEntry> outputs = new ArrayList<>();


annotate this with @Property. i would also suggest renaming this to output

WaitingIdly · 2026-05-05T14:12:38Z

+            List<IRollingMachineCrafter.IRollingRecipe> recipes = new ArrayList<>(Crafters.rollingMachine().getRecipes());
+            recipes.removeIf(recipe -> recipe.getRegistryName().equals(r.getKey()));


create a new arraylist and then remove from that list? are you sure thats correct

WaitingIdly · 2026-05-05T14:13:28Z

+            List<IRollingMachineCrafter.IRollingRecipe> recipes = new ArrayList<>(Crafters.rollingMachine().getRecipes());
+            recipes.removeIf(recipe -> recipe.getRegistryName().equals(r.getKey()));
+        });
+        restoreFromBackup().forEach(r -> ModSupport.RAILCRAFT.get().rollingMachine.add(r.getKey(), r.getValue()));


cant do this, because RollingMachine#add runs #addScripted

WaitingIdly · 2026-05-05T14:15:32Z

+        return Crafters.rollingMachine().getRecipes().removeIf(r -> {
+            if (output.test(r.getRecipeOutput())) {
+                addBackup(Pair.of(r.getRegistryName(), r));
+                return true;
+            }
+            return false;
+        });


you can compact this significantly by using doAddBackup to this

Suggested change

return Crafters.rollingMachine().getRecipes().removeIf(r -> {

if (output.test(r.getRecipeOutput())) {

addBackup(Pair.of(r.getRegistryName(), r));

return true;

}

return false;

});

return Crafters.rollingMachine().getRecipes().removeIf(r -> {

return output.test(r.getRecipeOutput()) && doAddBackup(Pair.of(r.getRegistryName(), r));

});

which becomes

Suggested change

return Crafters.rollingMachine().getRecipes().removeIf(r -> {

if (output.test(r.getRecipeOutput())) {

addBackup(Pair.of(r.getRegistryName(), r));

return true;

}

return false;

});

return Crafters.rollingMachine().getRecipes().removeIf(r -> output.test(r.getRecipeOutput()) && doAddBackup(Pair.of(r.getRegistryName(), r)));

WaitingIdly · 2026-05-05T14:18:25Z

+import java.util.List;
+
+@RegistryDescription
+public class RollingMachine extends VirtualizedRegistry<Pair<ResourceLocation, IRollingMachineCrafter.IRollingRecipe>> {


IRollingMachineCrafter.IRollingRecipe stores the ResourceLocation, so theres no need to have it be Pair<ResourceLocation, IRollingMachineCrafter.IRollingRecipe> instead of just IRollingMachineCrafter.IRollingRecipe

WaitingIdly · 2026-05-05T18:13:31Z

+        if (time <= 0) {
+            GroovyLog.msg("Error adding Railcraft Blast Furnace recipe")
+                    .error()
+                    .add("time must be greater than 0, got: {}", time)
+                    .post();
+            return null;
+        }
+        if (slag < 0) {
+            GroovyLog.msg("Error adding Railcraft Blast Furnace recipe")
+                    .error()
+                    .add("slag must be non-negative, got: {}", slag)
+                    .post();
+            return null;
+        }


validate in the builder

WaitingIdly · 2026-05-05T18:14:46Z

+            if (time <= 0) {
+                msg.add("time must be greater than 0, got: {}", time);
+                time = IBlastFurnaceCrafter.SMELT_TIME;
+            }
+            if (slag < 0) {
+                msg.add("slag must be non-negative, got: {}", slag);
+                slag = 1;
+            }


if there are any messages, the validation fails. just do

Suggested change

if (time <= 0) {

msg.add("time must be greater than 0, got: {}", time);

time = IBlastFurnaceCrafter.SMELT_TIME;

}

if (slag < 0) {

msg.add("slag must be non-negative, got: {}", slag);

slag = 1;

}

msg.add(time <= 0, "time must be greater than 0, got: {}", time);

msg.add(slag < 0, "slag must be non-negative, got: {}", slag);

WaitingIdly · 2026-05-05T18:16:12Z

+        @Property
+        private FluidStack fluid;


instead of this, use fluidOutput from parent

WaitingIdly · 2026-05-05T18:16:28Z

+@RegistryDescription
+public class FluidFuels extends VirtualizedRegistry<FluidFuels.FuelEntry> {
+
+    private final Map<String, Integer> backupFuels = new HashMap<>();


this is now completely unused

WaitingIdly · 2026-05-05T18:17:36Z

+
+    public boolean remove(IRollingMachineCrafter.IRollingRecipe recipe) {
+        return Crafters.rollingMachine().getRecipes().removeIf(r -> {
+            if (r == recipe) {


if r == recipe well you can just do addBackup(recipe) + Crafters.rollingMachine().getRecipes().remove(recipe) then

WaitingIdly · 2026-05-05T18:17:59Z

 # Version of your mod.
 # This field can be left empty if you want your mod's version to be determined by the latest git tag instead.
-modVersion = 1.4.3
+modVersion = 1.4.4


undo changing the version

LonelyxiyaOVO · 2026-05-06T00:51:04Z

I've fixed it. Please take a look and let me know if there are any issues

WaitingIdly

one new thing. please actually resolve the other issues you have marked as resolved, but have not resolved.

LonelyxiyaOVO · 2026-05-06T04:04:01Z

check

LonelyxiyaOVO added 3 commits May 5, 2026 20:11

Railcraft compat

77aeaa5

Fix bug

f7c3701

Update railcraft_example.groovy

17e5d27

Wizzerinus reviewed May 5, 2026

View reviewed changes

WaitingIdly requested changes May 5, 2026

View reviewed changes

LonelyxiyaOVO added 5 commits May 6, 2026 00:06

optimize code

09cdcb9

Functional and logical bug fixes

dd77b78

Update FluidFuels.java

4ab6ae2

Update FluidFuels.java

99933e7

Update buildscript.properties

84d43bb

WaitingIdly requested changes May 5, 2026

View reviewed changes

optimize code

e6ff65d

WaitingIdly requested changes May 6, 2026

View reviewed changes

Comment thread src/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/CokeOven.java Outdated

LonelyxiyaOVO added 2 commits May 6, 2026 09:47

code

4e9ccdd

huh

f87af56

		List<IRollingMachineCrafter.IRollingRecipe> recipes = new ArrayList<>(Crafters.rollingMachine().getRecipes());
		recipes.removeIf(recipe -> recipe.getRegistryName().equals(r.getKey()));

Conversation

LonelyxiyaOVO commented May 5, 2026

Uh oh!

Wizzerinus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WaitingIdly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonelyxiyaOVO commented May 6, 2026

Uh oh!

WaitingIdly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LonelyxiyaOVO commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants